Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# What does this PR do? #32877

Open
7 tasks
Karliz24 opened this issue Apr 19, 2024 · 0 comments
Open
7 tasks

# What does this PR do? #32877

Karliz24 opened this issue Apr 19, 2024 · 0 comments

Comments

@Karliz24
Copy link

What does this PR do?

This PR fix:

  • Identifiers for llama3 in tests
  • Correct termination condition in chat completion example
  • Remove nightlies installation in readme

Fixes # (issue)

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

Publicación original de @mreso en meta-llama/llama-recipes#443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant