Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionImpl.unitCommand with empty List/Set as parameter #42

Open
Ketroc opened this issue Sep 26, 2020 · 1 comment
Open

ActionImpl.unitCommand with empty List/Set as parameter #42

Ketroc opened this issue Sep 26, 2020 · 1 comment

Comments

@Ketroc
Copy link
Contributor

Ketroc commented Sep 26, 2020

It would be a nice quality of life change to have unitCommand() do nothing if given an empty unit List/Set as a parameter. Since these lists are almost always generated in a way where they could be empty, we currently have to do an empty check or error handling for every unitCommand() call.
@Supalosa
Copy link
Contributor

+1 - if no objection i could add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Supalosa @Ketroc