-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for opam 2.2 on Windows #794
base: master
Are you sure you want to change the base?
Conversation
You can compile by running |
Could you rebase to the latest master? |
done
that does not work. Do you have a list of command to run for javascript beginners? I have yarn installed but (after having to modify package.json to get the right yarn version or something), it's complaining about ncc. |
Note from @dra27: this should be part of |
Co-authored-by: Kate <kit-ty-kate@outlook.com>
@kit-ty-kate, do you have some CI testing this GH action ? |
@hhugo I do in kit-ty-kate/mirage-torrent#2 but while the setup-ocaml succeeds, the builds fails while building dune:
|
I'm also testing this PR in hhugo/ocamlbuild#7 and see the same error. |
The following can probably be removed as well
|
Fixes #793
Joint work with @hhugo.
The current state of the branch works (as far as i could test) but the commit history will need to be cleaned so I'm opening this as draft for now.The support is also not the cleanest as it would be best to use the opam internal cygwin installation instead of installing one manually, but it will do for now i think.@smorimoto is there a way to regenerate the .cjs files automatically?