Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf-bash not detecting installed bash on OpenBSD #5887

Closed
jideelgh opened this issue Mar 19, 2024 · 13 comments
Closed

conf-bash not detecting installed bash on OpenBSD #5887

jideelgh opened this issue Mar 19, 2024 · 13 comments

Comments

@jideelgh
Copy link

jideelgh commented Mar 19, 2024

(OpenBSD 7.4, ksh)
conf-bash keeps asking to install bash every time "opam upgrade" is launched, while it's already installed.

I tried to let opam to install bash or to install it manually.
Bash is installed in /usr/local/bin/bash, I tried to symlink to /bin/bash, no success.
bash --version returns

GNU bash, version 5.2.15(1)-release (x86_64-unknown-openbsd7.4)
Copyright (C) 2022 Free Software Foundation, Inc.
[...]

I used ktrace to investigate some pledge/unveil issue, couldn't identify one.
I also tried to start opam w/ the --debug flag & adjusting the level with --debug-level flags, no obvious error message (except maybe "ocamlc not found", quite weird as ocamlc is well installed and reachable, may not be related).
(behavior identified because JaneStreet Base 0.16.0 added conf-bash as a dependency)

@mseri
Copy link
Member

mseri commented Mar 19, 2024

What version of opam are you using. Maybe some opam maintainer knows more, ping @kit-ty-kate @rjbou

@kit-ty-kate kit-ty-kate transferred this issue from ocaml/opam-repository Mar 19, 2024
@kit-ty-kate
Copy link
Member

I've transferred this issue to opam, where the issue most likely is.

@jideelgh
Copy link
Author

@mseri opam 2.1.5

@kit-ty-kate
Copy link
Member

@jideelgh what does pkg_info -mqP | grep bash give you?

@rjbou
Copy link
Collaborator

rjbou commented Mar 19, 2024

What is the output of opam var os-family?

@jideelgh
Copy link
Author

@rjbou bsd

@jideelgh
Copy link
Author

@kit-ty-kate shells/bash

@kit-ty-kate
Copy link
Member

ah it looks like it's my fault, i did an off-by-one error in https://github.com/ocaml/opam/pull/4396/files#diff-6c0a6590c49c5a229f469d627b9e9484f1b20c1fb5fb1c8102d64a3d2c1d09b6R187 ..

sorry about that

@kit-ty-kate
Copy link
Member

Actually it's already fixed in 4b060e7 by @mndrix

You can fix this by using the latest beta:

bash -c "sh <(curl -fsSL https://raw.githubusercontent.com/ocaml/opam/master/shell/install.sh) --dev"

@rjbou
Copy link
Collaborator

rjbou commented Mar 19, 2024

Should we backport the fix in 2.1.6 ?

@mseri
Copy link
Member

mseri commented Mar 19, 2024

Good idea, it seems a small enough fix on a possibly common future error to warrant a backport

@kit-ty-kate
Copy link
Member

Fair enough, I've backported the commit to #5870. We expect to release it a couple weeks after the next 2.2.0 beta.

I'll close this as it is fixed in master

@jideelgh
Copy link
Author

Glad I could help. That was fast :) Thank you all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants