Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonsai no longer builds with dune package management #10473

Open
gridbugs opened this issue May 1, 2024 · 1 comment
Open

Bonsai no longer builds with dune package management #10473

gridbugs opened this issue May 1, 2024 · 1 comment
Labels
package management

Comments

@gridbugs
Copy link
Collaborator

gridbugs commented May 1, 2024 •
edited

There's a regression resulting in the following error when using dune to build the dependencies of the package "bonsai" (which we've been using to evaluate dune package management):

ocamlfind: Config file not found - neither /Users/s/src/depend-on-bonsai/_build/.sandbox/afd0d45a7d1cb969e78f1a490724f4c3/_private/default/.pkg/ocamlfind/target/lib/findlib.conf nor the directory /Users/s/src/depend-on-bonsai/_build/.sandbox/afd0d45a7d1cb969e78f1a490724f4c3/_private/default/.pkg/ocamlfind/target/lib/findlib.conf.d
make: *** [install] Error 2
-> required by _build/_private/default/.pkg/zarith/target

The regression was introduced in 3ea5444

PR which changes back the offending line: #10474

I don't yet understand why that change caused the regression.
gridbugs added a commit to gridbugs/dune that referenced this issue May 1, 2024
@gridbugs
pkg: Undo change reversing order of env updates
3ea9185 
In 3ea5444 the order of env updates performed by packages was
reversed. This brought the behaviour of dune closer to opam but
introduced a regression which prevents ocamlfind from building with
dune package management.

Here's an issue for tracking investigating why this change caused the
regression: ocaml#10473

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
@gridbugs gridbugs mentioned this issue May 1, 2024
Merged
gridbugs added a commit to gridbugs/dune that referenced this issue May 1, 2024
@gridbugs
pkg: Undo change reversing order of env updates
e014525 
In 3ea5444 the order of env updates performed by packages was
reversed. This brought the behaviour of dune closer to opam but
introduced a regression which prevents ocamlfind from building with
dune package management.

Here's an issue for tracking investigating why this change caused the
regression: ocaml#10473

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs added a commit to gridbugs/dune that referenced this issue May 1, 2024
@gridbugs
pkg: Undo change reversing order of env updates
94e0828 
In 3ea5444 the order of env updates performed by packages was
reversed. This brought the behaviour of dune closer to opam but
introduced a regression which prevents ocamlfind from building with
dune package management.

Here's an issue for tracking investigating why this change caused the
regression: ocaml#10473

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
@Leonidas-from-XIV
Copy link
Collaborator

Complete shot in the dark, but maybe it has something to do with OCAMLFIND_DESTDIR that is set to the wrong place? However, I am wondering why it would then complain about the config file, maybe somehow OCAMLFIND_CONF is being set to something invalid?

gridbugs added a commit to gridbugs/dune that referenced this issue May 1, 2024
@gridbugs
pkg: Undo change reversing order of env updates
4068c3c 
In 3ea5444 the order of env updates performed by packages was
reversed. This brought the behaviour of dune closer to opam but
introduced a regression which prevents ocamlfind from building with
dune package management.

Here's an issue for tracking investigating why this change caused the
regression: ocaml#10473

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs added a commit to gridbugs/dune that referenced this issue May 2, 2024
@gridbugs
pkg: Undo change reversing order of env updates
64728c2 
In 3ea5444 the order of env updates performed by packages was
reversed. This brought the behaviour of dune closer to opam but
introduced a regression which prevents ocamlfind from building with
dune package management.

Here's an issue for tracking investigating why this change caused the
regression: ocaml#10473

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs added a commit that referenced this issue May 2, 2024
@gridbugs
pkg: Undo change reversing order of env updates (#10474)
e0e23ea 
In 3ea5444 the order of env updates performed by packages was
reversed. This brought the behaviour of dune closer to opam but
introduced a regression which prevents ocamlfind from building with
dune package management.

Here's an issue for tracking investigating why this change caused the
regression: #10473

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Leonidas-from-XIV @rgrinberg @gridbugs