Don't consider Sys STM tests negative on ARM64 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quite decent runtime compared to GitHub actions BTW 😃 |
|
This is all green across GitHub Actions and Multicoretests-CI modulo
I'll therefore merge in the interest of moving to an all-green CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little PR
SysSTMpositive (not expected to fail) andcountto 200for the new shiny macOS arm64 runners.
This matches what we already do on Linux (Intel + arm64).
The PR thereby fixes #359 and helps to regain a nice all-green CI starting point.
On the branch CI run I can see this is already all green for Multicoretests-CI
https://github.com/ocaml-multicore/multicoretests/runs/14071705952