Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make num_domains argument to Task.setup_pool optional #87

Open
dra27 opened this issue Oct 11, 2022 · 1 comment · May be fixed by #91
Open

Make num_domains argument to Task.setup_pool optional #87

dra27 opened this issue Oct 11, 2022 · 1 comment · May be fixed by #91

Comments

@dra27
Copy link

dra27 commented Oct 11, 2022

The OCaml 5.0 includes Domain.recommended_domain_count which seems to be a reasonable default value for Task.setup_pool. Making the argument optional is code-compatible with existing code.

This would also create a mechanism within Task to use Domain.recommended_domain_count without incurring the "unstable" alert on the Domain module.

@kayceesrk
Copy link
Contributor

This sounds like a good idea.

Separately, I am also wondering whether to make the pool an optional argument. The current pool can be fetched from the context now that we have an effect handler in domainslib.

@dra27 dra27 linked a pull request Oct 20, 2022 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants