Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make less commits in CI #305

Open
deemp opened this issue Apr 23, 2024 · 0 comments
Open

Make less commits in CI #305

deemp opened this issue Apr 23, 2024 · 0 comments
Assignees
Labels
(ci) Related to CI priority 3

Comments

@deemp
Copy link
Member

deemp commented Apr 23, 2024

Current solution

Currently, CI always commits updated atoms (link) and Markdown files (link).

Benefits

  • Devs can see almost immediately what parts of docs and what atoms have changed.
  • Diffs are shown using GitHub's functionality.
  • Updates can be overwritten by force pushes (assuming that usually, only one person works on a PR).

Downsides

  • A work-in-progress PR could have several pushes before being ready, each of which may (incorrectly) update the docs and flood with redundant commits.
  • If git is not configured properly locally, it is possible to end up with several merge commits (due to not pulling before committing again).

Suggestion

  • Add a comment when diff is non-empty (link).
  • Actually update the documentation only
    • on master
    • on workflow_dispatch

Benefits

  • Does not add unsolicited commits to an active PR.
  • Notifies the developer that some output in the docs has changed to review it (perhaps it was unintentional).

Downsides

  • Does not review the changes to the docs as part of the PR (it is possible to implement this, but would introduce some technical complexity).

Similar workflow

(link)

@deemp deemp added the (ci) Related to CI label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(ci) Related to CI priority 3
Projects
None yet
Development

No branches or pull requests

2 participants