Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnippetTestCase.java:261-265: Remove filter with... #3162

Closed
0pdd opened this issue May 3, 2024 · 2 comments · Fixed by #3180
Closed

SnippetTestCase.java:261-265: Remove filter with... #3162

0pdd opened this issue May 3, 2024 · 2 comments · Fixed by #3180

Comments

@0pdd
Copy link

0pdd commented May 3, 2024

The puzzle 3092-ad9ee9a7 from #3092 has to be resolved:

* @todo #3092:30min Remove filter with "rust-tests.eo". BinarizeMojo does not add rust
* dependencies to rust-tests after phi->unphi (see:
* <a href="https://github.com/objectionary/eo/issues/3145">this</a> for details).
* When it's resolved we need to remove the filter and make sure the snippet test
* {@link SnippetTestCase#runsTestsAfterPhiAndUnphi(Path)} still works.

The puzzle was created by Max Trunnikov on 02-May-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Copy link

github-actions bot commented May 3, 2024

@0pdd thanks for the report, here is a feedback:

  • The todo message contains a link which is not in a clickable form. It should be in markdown format for easy navigation.
  • The todo message is a bit complicated and might confuse the reader. It should be made more concise and clear.
  • The todo message refers to a function with a parameter type (Path) which might not be understood by the reader. It should provide more context or explanation about this function.

Suggestions:

  • Replace the link in the message with markdown format like this: [this](https://github.com/objectionary/eo/issues/3145)
  • Simplify the message to something like: "Remove filter with "rust-tests.eo" after BinarizeMojo issue is resolved. Ensure the snippet test still works."
  • Provide a brief explanation about the function runsTestsAfterPhiAndUnphi(Path) or remove it if it's not crucial to the todo.

Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4

@0pdd
Copy link
Author

0pdd commented May 3, 2024

@0pdd thanks for the report, here is a feedback: * The todo message contains a link which is not in ...

I see you're talking to me, but I can't reply since I'm not a chat bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant