Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMD check disabled for entire eo-runtime #3160

Open
c71n93 opened this issue May 2, 2024 · 3 comments · May be fixed by #3171
Open

PMD check disabled for entire eo-runtime #3160

c71n93 opened this issue May 2, 2024 · 3 comments · May be fixed by #3171

Comments

@c71n93
Copy link
Member

c71n93 commented May 2, 2024

Check out this line:

eo/eo-runtime/pom.xml

Line 327 in f184d9a

<exclude>pmd:.*</exclude>

Do we really need to disable PMD check for the whole eo-runtime? We should ignore eo-runtime/src/main/java/EOorg because of upper case in package name and $ in class names, but should we ignore the rest of eo-runtime?

There would be a lot of PMD violations for classes from eo-runtime/src/main/java/org/eolang if we turned PMD on.

@yegor256 WDYT?
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

@c71n93 thanks for the report, here is a feedback:

Problems

  • Clear Title Missing: The bug report's title is currently presented as a question. A concise, direct statement would be more effective.
  • Reproduction Steps Missing: The bug report does not include steps to recreate the issue.
  • Environment Information Missing: The report lacks details about the environment, such as the operating system and software version, where the issue happens.

Suggestion

Improve the bug report title to a concise, direct statement like "PMD Check Disabled for Entire eo-runtime".

Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4

@c71n93 c71n93 changed the title Why does PMD ignore the entire `eo-runtime'? PMD Check Disabled for Entire eo-runtime May 2, 2024
@c71n93 c71n93 changed the title PMD Check Disabled for Entire eo-runtime PMD check disabled for entire eo-runtime May 2, 2024
@c71n93 c71n93 changed the title PMD check disabled for entire eo-runtime PMD check disabled for entire eo-runtime May 2, 2024
@yegor256
Copy link
Member

yegor256 commented May 2, 2024

@c71n93 we just don't know how to enable it. If you know, please try

c71n93 added a commit to c71n93/eo that referenced this issue May 6, 2024
@c71n93
objectionary#3160 enable pmd for eo-runtime and exclude EOorg package
68f7bb9
c71n93 added a commit to c71n93/eo that referenced this issue May 6, 2024
@c71n93
objectionary#3160 resolve PMD violations for tests from eo-runtime/sr…
931958c 
…c/test/java/org/eolang
c71n93 added a commit to c71n93/eo that referenced this issue May 6, 2024
@c71n93
objectionary#3160 resolve PMD violations for tests from eo-runtime/sr…
22fa0a4 
…c/main/java/org/eolang
@c71n93 c71n93 linked a pull request May 6, 2024 that will close this issue
Open
c71n93 added a commit to c71n93/eo that referenced this issue May 6, 2024
@c71n93
objectionary#3160 fix code duplication for DataizedTest and resolve s…
8e82e95 
…ome new PMD violations
c71n93 added a commit to c71n93/eo that referenced this issue May 6, 2024
@c71n93
objectionary#3160 add todo
029b7b2
c71n93 added a commit to c71n93/eo that referenced this issue May 6, 2024
@c71n93
objectionary#3160 get rid of parametrized test
aa4542d
c71n93 added a commit to c71n93/eo that referenced this issue May 6, 2024
@c71n93
objectionary#3160 suppress false positive PMD.CloseResource
db2d4d5
c71n93 added a commit to c71n93/eo that referenced this issue May 6, 2024
@c71n93
objectionary#3160 restart CI
cf5db6a
@c71n93
Copy link
Member Author

c71n93 commented May 7, 2024

@c71n93 we just don't know how to enable it. If you know, please try

@yegor256 Did you mean this (#3171 (comment)) problem in your comment?

c71n93 added a commit to c71n93/eo that referenced this issue May 10, 2024
@c71n93
objectionary#3160 set up file.encoding to UTF8
33b264a
c71n93 added a commit to c71n93/eo that referenced this issue May 13, 2024
@c71n93
objectionary#3160 remove file.encoding
1286ee0
c71n93 added a commit to c71n93/eo that referenced this issue May 13, 2024
@c71n93
objectionary#3160 restart CI
5f15eb3
c71n93 added a commit to c71n93/eo that referenced this issue May 13, 2024
@c71n93
objectionary#3160 remove unnecessary import
058015a
c71n93 added a commit to c71n93/eo that referenced this issue May 14, 2024
@c71n93
objectionary#3160 shortened the variable name
380976e
c71n93 added a commit to c71n93/eo that referenced this issue May 14, 2024
@c71n93
objectionary#3160 copy array instead of storing directly
b2a049c
c71n93 added a commit to c71n93/eo that referenced this issue May 16, 2024
@c71n93
objectionary#3160 resolve PMD.ConstructorShouldDoInitialization warning
d3a8376
c71n93 added a commit to c71n93/eo that referenced this issue May 16, 2024
@c71n93
objectionary#3160 locatr
f4a0dd2
c71n93 added a commit to c71n93/eo that referenced this issue May 16, 2024
@c71n93
objectionary#3160 remove PhWrite
b63ec99
c71n93 added a commit to c71n93/eo that referenced this issue May 16, 2024
@c71n93
objectionary#3160 add todo for refactoring
88d82de
c71n93 added a commit to c71n93/eo that referenced this issue May 16, 2024
@c71n93
objectionary#3160 fix todo
2e6fade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3160 Enable PMD for eo-runime c71n93/eo
2 participants
@yegor256 @c71n93