Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3162): phi-unphi snippet test with rust #3180

Merged
merged 2 commits into from May 13, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented May 9, 2024

Closes: #3162


PR-Codex overview

This PR removes a filter in SnippetTestCase.java related to copying files for rust-tests.eo.

Detailed summary

  • Removed filter for "rust-tests.eo" in copySources method
  • Updated comments regarding the filter removal and its purpose

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 13, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 0c0ed41 into objectionary:master May 13, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented May 13, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 24min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SnippetTestCase.java:261-265: Remove filter with...
3 participants