eoc test fails after eoc unphi #2873
Comments
1 task
|
Normalized phi expression is incorrect
|
|
@deemp there's also bug in our |
|
Okay. eoc test fails without normalization. Workflow: https://github.com/objectionary/normalizer/actions/runs/7844948642/job/21408311976#step:6:39 Initial EO Converted to PHI Converted back to EO unphi warning Test |
|
@deemp could you please provide me full phi from here?
|
|
@maxonfjvipon, where does it come from? This phi has less than 346 columns. I used this script for testing without normalization. https://github.com/objectionary/normalizer/blob/601a878f42813184eda6208b12ff3b0b1a449e8c/pipeline.sh I reused mkdir -p eo-not-normalized
cd phi
cp -r ../eo/.eoc .
eo unphi |
This phi expression is not parsable by our Phi parse because of #2864 |
|
Switched eo repo to as-phi.eo |
|
@deemp do you use test sources from EO 0.35.2? |
|
Yes. as-phi-tests.eo bool-tests.eo |
|
|
|
@deemp we updated sourced in objectionary/home, please try again |
|
Still |
|
If I use the |
|
Current summary. I want to run
How do I generate phi files and then unphi them using the latest eo? |
|
@deemp I released eoc 0.16.0. It seems that it works with your example out of the box. Please try: |
|
It fails at Error as-phi-tests.eo as-phi-tests.phi |
|
I used There's an error during [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.2.5:test (default-cli) on project eoc: No tests were executed! (Set -DfailIfNoTests=false to ignore this error.) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
The command "/home/eyjafjallajokull/Desktop/gh/normalizer/node_modules/eolang/mvnw/mvnw surefire:test -Deo.version=0.35.2 -Deo.hash=130afdd1456a0cbafd52aee8d7bc612e1faac547 --quiet -Deo.sourcesDir=/home/eyjafjallajokull/Desktop/gh/normalizer/pipeline/eo-not-normalized -Deo.targetDir=/home/eyjafjallajokull/Desktop/gh/normalizer/pipeline/eo-not-normalized/.eoc -Deo.outputDir=/home/eyjafjallajokull/Desktop/gh/normalizer/pipeline/eo-not-normalized/.eoc/classes -Deo.generatedDir=/home/eyjafjallajokull/Desktop/gh/normalizer/pipeline/eo-not-normalized/.eoc/generated-sources -Deo.placed=/home/eyjafjallajokull/Desktop/gh/normalizer/pipeline/eo-not-normalized/.eoc/eo-placed.csv -Deo.placedFormat=csv --batch-mode --color=never --update-snapshots --fail-fast --strict-checksums" exited with #1 codebool-tests.eo bool-tests.phi (after bool-tests.eo (after |
|
@deemp the problem is that the We should think about representing EO tags somehow in the |
|
With this fix, as-phi-tests.eo as-phi-tests.phi |
|
!!!I can't reproduce!!! Fails on as-phi-tests.phi (after normalization) as-phi-tests.eo (after unphi) |
|
Hmm, can't reproduce this error when I run only as-phi-tests.eo. |
|
However, I can reproduce an error when running bool-tests.eo bool-tests.phi bool-tests.eo (after unphi) |
|
@rultor release, tag is |
|
You can see the full PR. It contains a GH Action that runs the pipeline. Here is one of the runs. |
|
@yegor256 do you know what's going on here? |
|
@maxonfjvipon I see this in the log: |
|
@maxonfjvipon this is the problem: objectionary/eoc#253 |
|
@deemp my bad, the latest version if |
|
Finally, the pipeline works. https://github.com/objectionary/normalizer/actions/runs/8178774742 I think this issue can be closed. |
|
Sorry. I didn't enable all tests at the time of writing the previous message. |
|
ram-tests.eo Errors |
|
Should I update something on my side? |
|
@yegor256 it seems we need to make a new release. Let's make it with tag |
|
@rultor release, tag is |
|
@deemp no, just wait a bit |
|
@yegor256 let's try again with 0.35.8 |
|
@rultor release, tag is |
|
@maxonfjvipon finally |
|
@deemp we finally released all we wanted, please use EO |
|
Got an error |
|
@deemp there's a bug in our phi parser. |
|
@maxonfjvipon @deemp maybe it's better to close this issue and report new problems in separate issues? |
|
@yegor256 I agree |
|
Okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I used
eoc 0.15.1Workflow: https://github.com/objectionary/normalizer/actions/runs/7843597391/job/21404276775#step:6:36
Pipeline script: https://github.com/objectionary/normalizer/blob/53ce6966b4df5e138a4ce22214c6c697720ea0c1/pipeline.sh
Initial EO
Converted to PHI
Normalized
Converted back to EO
eoc testerror:The text was updated successfully, but these errors were encountered: