Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay Dues link is still offered when BSA validation shows expired #54

Open
justdave opened this issue Jan 15, 2022 · 0 comments
Open

Pay Dues link is still offered when BSA validation shows expired #54

justdave opened this issue Jan 15, 2022 · 0 comments
Labels

Comments

@justdave
Copy link
Member

This might be a regression from when the BSA Validation stuff all changed... it was supposed to not give you the link to pay dues and show a message that your BSA membership couldn't be verified in that spot if your membership check failed.

It looks like it is doing this if it failed to find your ID, but if your ID was found but it was expired, it's not showing the BSA validation message in the dues spot (only showing it below in the BSA spot).

The current code also seems to be showing the link regardless, even though it shows the message saying your membership isn't valid if you're not registered.

@justdave justdave added the bug label Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant