Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong excepted retval in nyx.h #20

Open
azanegin opened this issue Oct 24, 2022 · 0 comments · May be fixed by #21
Open

wrong excepted retval in nyx.h #20

azanegin opened this issue Oct 24, 2022 · 0 comments · May be fixed by #21

Comments

@azanegin
Copy link

packer/nyx.h

Line 243 in ef990c6

*hprintf_buffer = (uint8_t*)mmap((void*)NULL, HPRINTF_MAX_SIZE, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);

packer/nyx.h

Line 245 in ef990c6

if(!*hprintf_buffer){

On linux userspace targets at least, this will probably lead to an error.

Citing 'man mmap':

On error, the value MAP_FAILED (that is, (void *) -1) is returned, and errno is set to indicate the error.
@azanegin azanegin linked a pull request Nov 7, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nyx.h hprintf buffer issue fix azanegin/packer
1 participant
@azanegin