Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Issue with gradle plugin 3.4.0 #383

Open
kalyandechiraju opened this issue May 13, 2019 · 11 comments
Open

Issue with gradle plugin 3.4.0 #383

kalyandechiraju opened this issue May 13, 2019 · 11 comments

Comments

@kalyandechiraju
Copy link

kalyandechiraju commented May 13, 2019

When I update my gradle plugin version to 3.4.0, import com.nytimes.android.external.store3.base.impl.Store is not able to be resolved.
But it's working fine if I revert back to gradle plugin version 3.3.2.

Is this any problem with the library or just another plugin issue?

@kalyandechiraju kalyandechiraju changed the title When I update my gradle plugin version to 3.4.0, import com.nytimes.android.external.store3.base.impl.Store is not able to resolved. Issue with gradle plugin 3.4.0 May 13, 2019
@pavlospt
Copy link
Contributor

Hey @kalyandechiraju do you have a stacktrace?

@kalyandechiraju
Copy link
Author

It's just a compile-time error saying unable to resolve com.nytimes.android.external.store3.base.impl.Store Due to which my build is failing.

@digitalbuddha
Copy link
Contributor

Can you create a failing sample project? I'm unable to reproduce. Could be a proguard configuration you are using

@kalyandechiraju
Copy link
Author

Sure. @digitalbuddha

Here is a sample project running on AS Gradle plugin 3.4.1 and gradle 5.1.1
https://github.com/kalyandechiraju/StoreDemo

Check the Main Activity class (master branch) where the Store interface is not resolvable.

Whereas in gradle3.3 branch running on gradle plugin 3.3.x and gradle 4.10.1, it's resolved properly.

@cybo42
Copy link
Contributor

cybo42 commented May 21, 2019

I've been able to reproduce this in the sample app as well. Both upgrading to AGP 3.4.1 or upgrading Gradle to 5.0> seems to cause compile errors. I will try to see if I can take a closer look at this.

@kalyandechiraju
Copy link
Author

Any update on this?

@polivmi1
Copy link

Any updates?

@kalyandechiraju
Copy link
Author

Any workaround for this? I am not able to upgrade the gradle plugin due to this.

@kalyandechiraju
Copy link
Author

I tried cloning the project and updating the Gradle plugin. After updating, Gradle sync fails with this error:
ERROR: The Android Gradle plugin supports only Kotlin Gradle plugin version 1.3.10 and higher.
The following dependencies do not satisfy the required version:
root project 'Store' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.0
Affected Modules: app

Can anyone check this and take necessary action? Also, please confirm if this is the cause for the issue.

@kalyandechiraju
Copy link
Author

Finally able to solve the issue by adding Store3 dependency in addition to store-kotlin3 dependency.

implementation 'com.nytimes.android:store3:3.1.1' <-- Previously I dont have this dependency
implementation 'com.nytimes.android:store-kotlin3:3.1.1'
implementation 'com.nytimes.android:middleware3:3.1.1'

@polivmi1
Copy link

Just add com.nytimes.android:cache3:3.1.1 dependency

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants