Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid regex syntax causes infinite redirects #62

Open
devinellis opened this issue Feb 15, 2017 · 1 comment
Open

Invalid regex syntax causes infinite redirects #62

devinellis opened this issue Feb 15, 2017 · 1 comment

Comments

@devinellis
Copy link

I accidentally added a redirect with a trailing pipe character. This caused it to infinite redirect ALL retour redirects, it seems. I recommend adding some sort of syntax validation before allowing the user to save a static Regex redirect, like:

preg_match('~InvalidRegular)Expression~', null) === false

from http://stackoverflow.com/questions/4440626/how-can-i-validate-regex

@khalwat
Copy link
Contributor

khalwat commented Feb 16, 2017

Ouch. Preflighting certainly seems like a good idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants