Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imgix - Domain name checking #204

Open
Coysh opened this issue May 26, 2020 · 2 comments
Open

Imgix - Domain name checking #204

Coysh opened this issue May 26, 2020 · 2 comments
Assignees
Labels

Comments

@Coysh
Copy link

Coysh commented May 26, 2020

On entering my imgix source, I incorrectly entered the protocol as well.
This errored the site with a
InvalidArgumentException: Domain must be passed in as fully-qualified domain name and should not include a protocol or any path element, i.e. "example.imgix.net".

From vendor/imgix/imgix-php/src/Imgix/UrlBuilder.php on line 37.

Should there by a pre-check before saving? Had to manually edit the project.yaml file and revert back

@khalwat khalwat self-assigned this Jun 8, 2020
@khalwat
Copy link
Contributor

khalwat commented Jun 8, 2020

We should either validate this, or strip the protocol before passing it in -- and at least throw a try/catch around it.

@khalwat khalwat added the bug label Jun 8, 2020
@alexwybraniec
Copy link

+1 for this. Going to make a PR for the Docs to make the requirement clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants