Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the process for translators #2

Open
nvdaes opened this issue Jan 9, 2020 · 3 comments
Open

Document the process for translators #2

nvdaes opened this issue Jan 9, 2020 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented Jan 9, 2020

Regardless of the documentation for a multilingual store, add-ons are translatable and this should be documented ASAP to avoid deletions or regressions, given that they are in fact translated, using the system created by @mhameed:

  • Documentation, gettext messages and translatable mainfest keys could be sent to the system when a PR is approved or merged.
  • Translated messages can be included in the add-on source code and binary and the corresponding commit could be automatically added to the submission repo, deleting the commit against it was created. This shouldn't require to be reviewed and maybe automatically posted on the store, if translations are sent periodically in a programed way as done now with automatic.crontab.
@feerrenrut
Copy link
Contributor

To start with, it will be more productive to be agnostic of translations. Translations can be stored in the addon repo, and be submitted with the addon as part of a version submission. Storing the translations in the addon repo means no extra steps necessary in this proposal, and also translations are available for the addon if it is distributed outside of the store.

Perhaps you are concerned about how this will affect the frequency of necessary addon submissions? Once we get a working prototype of this system, we can look at the "nice to haves" that speed up tedious or repetitive manual processes.

One thing that should be expanded on, is to point out that translated values for user visible strings will need to be returned by the endpoint for fetching addon lists. This is relatively straightforward, the thing that would be easy to miss here is that including the required presentation language code is necessary when calling the endpoint.

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Jan 10, 2020 via email

@feerrenrut
Copy link
Contributor

How translations fits into this process is definitely something to consider. Though streamlining that particular reason for submissions can happen after we nail down the core process and have a demo system working.

@seanbudd seanbudd added the documentation Improvements or additions to documentation label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants