make better messages for incomplete string #12868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #12795
The issue is caused by an empty position of
ParseError::UnexpectedEof
. So no detailed message is displayed.To fix the issue, I adjust the start of span to
span.end - 1
. In this way, we can make sure that it never points to an empty position.After lexing item, I also reorder the unclosed character checking . Now it will be checking unclosed opening delimiters first.
User-Facing Changes
After this pr, it outputs detailed error message for incomplete string when running scripts.
Before
After
Tests + Formatting
Added some tests for incomplete string.