Skip to content
This repository has been archived by the owner on Jun 4, 2023. It is now read-only.

Check nu version during package installation and warn if it's not the one declared in metadata #122

Open
skelly37 opened this issue Nov 5, 2022 · 0 comments
Labels
delight Not planned but also not dropped, nice to have feature-request New feature or request good first issue Good for newcomers priority: low No hurry, can wait to any other minor release

Comments

@skelly37
Copy link
Member

skelly37 commented Nov 5, 2022

Related problem

It'd be nice to check at install-time whether the user has a compatible nu version or not, to avoid unexpected behavior during the runtime

Describe the solution you'd like

Compare nu -v with the package metadata before finishing the nupac's installation to prompt when the versions are not the same.

Implement 3 ways of NUPAC_NU_VERSION_BEHAVIOR

  • require: block installation with incorrect nu version
  • warn: (default) just print a warning
  • ignore: no info at all, the user accepts the risk

Describe alternatives you've considered

No response

Additional context and details

@skelly37 skelly37 added feature-request New feature or request good first issue Good for newcomers question Further information is requested priority: low No hurry, can wait to any other minor release delight Not planned but also not dropped, nice to have labels Nov 5, 2022
@skelly37 skelly37 modified the milestone: 0.1.0 pre-release Nov 5, 2022
@skelly37 skelly37 changed the title Check nu version during nupac installation and warn if it's not the one we're working with Check nu version during package installation and warn if it's not the one declared in metadata Nov 5, 2022
@skelly37 skelly37 removed the question Further information is requested label Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
delight Not planned but also not dropped, nice to have feature-request New feature or request good first issue Good for newcomers priority: low No hurry, can wait to any other minor release
Projects
None yet
Development

No branches or pull requests

1 participant