Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: add serve dashboard command / static page #232

Open
cbraillon opened this issue Jul 25, 2019 · 18 comments
Open

Improvement: add serve dashboard command / static page #232

cbraillon opened this issue Jul 25, 2019 · 18 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cbraillon
Copy link

Q A
Bug report? no
Feature request? yes
Library version latest

It would be great to see results in a dashboard.
I know that Symfony Insight has one and it's awesome.

It will increase the readability of issues.

@caneco
Copy link
Contributor

caneco commented Jul 25, 2019

I wouldn't mind to tackle this… 🔥 🔥 🔥

@olivernybroe
Copy link
Collaborator

We have a PR for adding formatters #201, which will make doing this a lot easier.

I see two ways of implementing this. Either create a new formatter called html, which generates a site from the output. Or create a site which can load the data from the json format.

@caneco
Copy link
Contributor

caneco commented Jul 25, 2019

@olivernybroe in each run we could add a new JSON file to a specific folder that a HTML would read an present the key figures and charts.

Feels like the best approach, and also to show the progress of the insights results.

@olivernybroe
Copy link
Collaborator

@caneco Sounds like a good idea. I think the JSON way is more robust and extendable in the future.

Would also do so you could compare your results for each run 👍

Maybe this dashboard should be a package for itself that you can just composer require in?

@caneco
Copy link
Contributor

caneco commented Jul 25, 2019

Could be something installed if needed with npm run install && npm run build/serve?

@olivernybroe
Copy link
Collaborator

@caneco Yeah, it makes a ton of sense to use npm instead as it is front end stuff.

@caneco
Copy link
Contributor

caneco commented Jul 25, 2019

Another question…

Should the dashboard be:

  • only available by running a local server (npm run serve)
  • available as a "static" website in the repo (npm run build)
  • or… both

@olivernybroe
Copy link
Collaborator

I think a static site might be the best choice, if that is not too much work. Else just do what you find easiest.

@cbraillon
Copy link
Author

Love the idea of a static site !

@olivernybroe olivernybroe added the enhancement New feature or request label Jul 26, 2019
@olivernybroe olivernybroe pinned this issue Jul 26, 2019
@nunomaduro nunomaduro changed the title Add a dashboard Improvement: add serve dashboard command Aug 15, 2019
@nunomaduro nunomaduro changed the title Improvement: add serve dashboard command Improvement: add serve dashboard command / static page Aug 15, 2019
@nunomaduro nunomaduro added the help wanted Extra attention is needed label Aug 15, 2019
@nunomaduro
Copy link
Owner

Thanks to @olivernybroe, we can know get json format from phpinsights.

@Gummibeer
Copy link
Contributor

I also would like static html files more. And at the end it's just adding tag wrappers around the already present text format?
<dl>, <ul> and this kind of stuff should do the trick?

@Gummibeer
Copy link
Contributor

Will try to add a HTML formatter which generates a static file.

@Gummibeer
Copy link
Contributor

I'm 💯 % not in design! But this is my first/working result. I've tried to rebuild the console output - because I'm a lazy-bitch I use bootstrap. 🙈
My idea is that anyone else can make it pretty if wanted, but for the moment it should be fine!?

screencapture-localhost-63342-phpinsights-dashboard-html-2019-08-28-14_58_11

@nunomaduro
Copy link
Owner

@caneco

@lloricode
Copy link

I'm 100 % not in design! But this is my first/working result. I've tried to rebuild the console output - because I'm a lazy-bitch I use bootstrap. see_no_evil My idea is that anyone else can make it pretty if wanted, but for the moment it should be fine!?

screencapture-localhost-63342-phpinsights-dashboard-html-2019-08-28-14_58_11

love this one, can we have that one?

@emjayess
Copy link

@Gummibeer what's the present status of your html output/format? And, just as importantly, where is it? :)

@Gummibeer
Copy link
Contributor

It's there https://github.com/nunomaduro/phpinsights/pull/258/files and the PR status says it all. 😉

@Wulfheart
Copy link

I am not sure if this is already present. I can't see it in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants