Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partition filter parsing to the adapter #1138

Open
stevenaw opened this issue Nov 22, 2023 · 4 comments
Open

Add partition filter parsing to the adapter #1138

stevenaw opened this issue Nov 22, 2023 · 4 comments

Comments

@stevenaw
Copy link
Member

We added partitioning to the framework in nunit/nunit#4391

https://github.com/nunit/nunit/blob/6fa2c0cc21c08e2b229c248b1af228e4596f4e71/src/NUnitFramework/framework/Internal/TestFilter.cs#L191-L193

Parsing support was added to the console in nunit/nunit-console#1346

@OsirisTerje noted that we need to add parsing support in the adapter as well nunit/nunit#4391 (comment)

@OsirisTerje
Copy link
Member

@Plasma Do you want to grab this one too?

@chris-smith-zocdoc
Copy link

@OsirisTerje I may have some bandwidth to take this, can you point me at the correct file I should be looking at?

@chris-smith-zocdoc
Copy link

@OsirisTerje I took a look at this, and it appears to already work with the latest master/pre-release version on myget.

<PackageReference Include="NUnit3TestAdapter" Version="5.0.0-beta.2" />

I see the partitioning working when I run it like this

dotnet test -v:n -- NUnit.Where='partition==2/2' NUnit.Verbosity=5

Is there somewhere I can track for the 5.0.0 release? I'll see if we're able to use the myget version until its published on nuget

@chris-smith-zocdoc
Copy link

chris-smith-zocdoc commented May 16, 2024

It does look like the partition isn't passed directly though though, the test discovery appears to transform it into

<filter><or><test>one</test><test>two</test></or></filter>

which isn't ideal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants