feat: Stream mapper implementation of MapStreamBatchFn. Fixes #1688
#1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s at once enabling batch processing of mapped items
This was referenced Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements backend for updated stream mapper (
MapStreamBatchFn) implemented here: numaproj/numaflow-go#129It allows stream mapper to have readBatchSize > 1.
readBatchSize == 1, the capability today is executed as-isreadBatchSize >= 1, the newer interface will be used.Individual langauge servicers can be implemetned to have the default handler for
MapStreamBatchFnsimply iterate over the one-item implementation so that it should be completely backwards compatible for everyone. But now those who wish to implement handling more than datum item at a time, the capability is now exposedFixes: #1688 and partial fix of #1564