Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use container-type ENV to name server-info and UDS file #1666

Open
vigith opened this issue Apr 13, 2024 · 1 comment
Open

use container-type ENV to name server-info and UDS file #1666

vigith opened this issue Apr 13, 2024 · 1 comment

Comments

@vigith
Copy link
Contributor

vigith commented Apr 13, 2024

Since we cannot have two different container types, we could do as follows.

${prefix}/numaflow/${UDContainer-type}/server-info
${prefix}/numaflow/${UDContainer-type}/uds.sock

{$prefix} could be /tmp/ or /var/run/ based on NUMAFLOW_POD env var, so it is easy to start the server locally.

@whynowy
Copy link
Member

whynowy commented Apr 13, 2024

Maybe just use the ud container type env existence to determine if it's local or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants