Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page_router fails if URL has hash(#) fragment #161

Open
gapmiss opened this issue Jan 13, 2024 · 3 comments
Open

page_router fails if URL has hash(#) fragment #161

gapmiss opened this issue Jan 13, 2024 · 3 comments
Labels

Comments

@gapmiss
Copy link

gapmiss commented Jan 13, 2024

Testing out nuemark and having issues with the page router.

For example:

A page with a nuemark tabs component
http://localhost:8080/index.html

click a tab and the url changes to
http://localhost:8080/index.html#tab-1

click link to a different page
http://localhost:8080/example.html

click browser's back button and the URL is again
http://localhost:8080/index.html#tab-1

however, the page content is still from the example.html

screencast:

CleanShot-Firefox-Markdown with megapowers-2024-01-13-09 07 13

@tipiirai
Copy link
Contributor

Ahh... good catch. I forgot to implement the collaboration between the tabs component and the page-router. Thanks!

@tipiirai tipiirai added the bug label Jan 15, 2024
@fritx
Copy link
Collaborator

fritx commented Apr 18, 2024

Forgive me I might be off-topic, but I'm borrowing the topic of "page_router":

Is the page_router in site.yaml now deprecated in favor of router: true|false?
I'm seeing only if (data.router) push('page_router')...

But there are still two places that using page_router: true in create-www

@nobkd
Copy link
Collaborator

nobkd commented Apr 18, 2024

@fritx yes, it has been replaced. See #113 with its closing commit be2f19a. Then this should be corrected in create and www

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants