Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer: trigger backoff via E_FIN_FAILED #116

Open
jehiah opened this issue Feb 11, 2015 · 1 comment
Open

consumer: trigger backoff via E_FIN_FAILED #116

jehiah opened this issue Feb 11, 2015 · 1 comment

Comments

@jehiah
Copy link
Member

jehiah commented Feb 11, 2015

A consumer can become overwhelmed with messages such that when it's completing them they have already server-side timed out. In this case the client thinks it's ok and keeps FIN'ing messages and getting more and may never be able to work off it's backlog (this situation is worse the higher max-in-flight used).

go-nsq could use the presense of E_FIN_FAILED to trigger backoff just like failing processing in the handler would. This will trigger RDY changes such that message flow drops off so the consumer can recover.

@mreiferson
Copy link
Member

this is a great idea 👍

@mreiferson mreiferson changed the title Trigger backoff via E_FIN_FAILED consumer: trigger backoff via E_FIN_FAILED Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants