Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvement: DateTime + FiniteDuration syntax #118

Open
GMadorell opened this issue May 18, 2017 · 0 comments
Open

Possible improvement: DateTime + FiniteDuration syntax #118

GMadorell opened this issue May 18, 2017 · 0 comments

Comments

@GMadorell
Copy link

Hi!

Recently I've seen something missing from this library, the ability to add a duration to a date time. I've written an extension class for this myself, but maybe something similar could be added to nscala-time? If you think that's cool, I could probably work in a PR to add this feature.

import scala.concurrent.duration.FiniteDuration

import org.joda.time.DateTime

object DateTimeSyntax {
  implicit class RichDateTime(dateTime: DateTime) {
    def minus(duration: FiniteDuration): DateTime = dateTime.minusMillis(duration.toMillis.toInt)
    def -(duration: FiniteDuration): DateTime     = minus(duration)
    def plus(duration: FiniteDuration): DateTime  = dateTime.plusMillis(duration.toMillis.toInt)
    def +(duration: FiniteDuration): DateTime     = plus(duration)
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant