Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nvmc: make PAGE_SIZE and WORD_SIZE public constants #393

Open
eflukx opened this issue Jul 11, 2022 · 2 comments
Open

Nvmc: make PAGE_SIZE and WORD_SIZE public constants #393

eflukx opened this issue Jul 11, 2022 · 2 comments

Comments

@eflukx
Copy link

eflukx commented Jul 11, 2022 •
edited

Would it make sense to make the constant nrf_hal::nvmc::PAGE_SIZE and WORD_SIZE public, so these can be used in application code? (and one doesn't have to rely on locally set constant, with the same value)
@eflukx eflukx changed the title Make nvmc::PAGE_SIZE public Nvmc: make PAGE_SIZE and WORD_SIZE public constants Jul 11, 2022
@eflukx
Copy link
Author

eflukx commented Oct 3, 2022

Hmmm it remains very silent.. ;)
Is it an option to change the visibility of this const? Would it be helpful for me to make a PR?

@jonas-schievink
Copy link
Contributor

This seems like a good idea, yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eflukx @jonas-schievink