Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on crates.io #375

Open
GreenPenguino opened this issue Jan 18, 2022 · 0 comments
Open

Broken links on crates.io #375

GreenPenguino opened this issue Jan 18, 2022 · 0 comments

Comments

@GreenPenguino
Copy link

GreenPenguino commented Jan 18, 2022

The relative links in README.md are broken on crates.io. The links work correctly on Github. It seems like the base URL on crates.io is incorrect.

Working and broken example:
Link on Github: https://github.com/nrf-rs/nrf-hal/blob/master/nrf51-hal (works correctly)
Link on crates.io: https://github.com/nrf-rs/nrf-hal/blob/nrf51-hal (does not work)

The issue is the missing /master/ between blob and the location name. This issue breaks all the relative links in README.md on crates.io.

bors bot added a commit that referenced this issue Feb 4, 2022
377: Split readme and avoid most broken links r=jonas-schievink a=jonas-schievink

Largely avoids #375, just the license file links are broken now.

bors r+

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
bors bot added a commit that referenced this issue Feb 4, 2022
377: Split readme and avoid most broken links r=jonas-schievink a=jonas-schievink

Largely avoids #375, just the license file links are broken now.

bors r+

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant