Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UARTE: stopbits setting not exposed #354

Open
jnordholz opened this issue Aug 28, 2021 · 1 comment
Open

UARTE: stopbits setting not exposed #354

jnordholz opened this issue Aug 28, 2021 · 1 comment

Comments

@jnordholz
Copy link

Hi,

I'm working on a NRF52840-based design and need the UART configured as 8N2, but the UARTE driver doesn't expose CONFIG.STOP yet. I've created a simple PR (#353) that adds another parameter to the Uarte::new() constructor (next to the already existing "parity" parameter), but of course that's an incompatible API change.

Thanks for considering!

@jnordholz
Copy link
Author

Ah, that's a 52840-specific feature (PR closed, sorry for the noise) - so then a cfg-guarded setter would be easier to integrate, however tweaking these settings usually requires disabling the peripheral, which is why these things are usually handled in the setup phase... I'll happily update my PR if you have an opinion where this should go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant