Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Commercial Usage of Master #63

Closed
8 tasks done
rHorsey opened this issue Jun 24, 2019 · 3 comments
Closed
8 tasks done

Enable Commercial Usage of Master #63

rHorsey opened this issue Jun 24, 2019 · 3 comments
Assignees
Labels
DO NOT MERGE PR is open but please don't merge!

Comments

@rHorsey
Copy link
Contributor

rHorsey commented Jun 24, 2019

Issue to track requirements for Commercial usage of buildstockbatch. Initial todos:

  • OpenStudio version abstraction in base.py through yml
  • sys_image_dir abstraction in eagle.py and hpc.py through yml
  • Add requests status code check in hpc.py for pulling down singularity container
  • Include results directory protection behavior
  • Enable custom bundle option in hpc.py for non-linked gems (i.e. OpenStudio Standards)
  • Add commercial workflow
  • Enable precomputed sampling
  • Ensure lack of BuildingCharacteristicReport is not a problem
@rHorsey rHorsey self-assigned this Jun 24, 2019
@rHorsey rHorsey added the DO NOT MERGE PR is open but please don't merge! label Jun 24, 2019
@rHorsey
Copy link
Contributor Author

rHorsey commented Jun 24, 2019

All items above believed to be satisfied by #65 however testing is required (unit & on eagle.)

@nmerket nmerket added this to Review in progress in BuildStock Batch Oct 10, 2019
@asparke2
Copy link
Member

asparke2 commented May 5, 2021

@rHorsey can we close this issue? ComStock can definitely be run on local docker and on Eagle using the code on master. I haven't tried testing AWS, but IMO that isn't worth keeping this issue over.

@nmerket
Copy link
Member

nmerket commented Oct 27, 2022

Fixed in #238

@nmerket nmerket closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is open but please don't merge!
Projects
No open projects
BuildStock Batch
  
Review in progress
Development

No branches or pull requests

3 participants