Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug on output dir restriction for buildstock_eagle #393

Closed
lixiliu opened this issue Sep 14, 2023 · 0 comments · Fixed by #397
Closed

Minor bug on output dir restriction for buildstock_eagle #393

lixiliu opened this issue Sep 14, 2023 · 0 comments · Fixed by #397
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lixiliu
Copy link
Contributor

lixiliu commented Sep 14, 2023

Describe the bug
When running bsb on Eagle, the check on output_directory should include the absolute path too.

buildstockbatch.exc.ValidationError: output_directory must be in /scratch or /projects, output_directory = /lustre/eaglefs/scratch/lliu2/resstock/project_national/national_baseline

To Reproduce
Clone resstock repo to scratch and run sampling on project_national/national_baseline.yml.

Expected behavior
bsb should be able to register that output dir is in fact in scratch since the cloned resstock repo is in scratch

Platform (please complete the following information):

  • Simulation platform: Eagle
  • BuildStockBatch version, branch, or sha: buildstock-2023.06.0
  • resstock or comstock repo version, branch, or sha: any
@lixiliu lixiliu added the bug Something isn't working label Sep 14, 2023
@nmerket nmerket added this to the v2023.10.0 milestone Oct 9, 2023
nmerket added a commit that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants