Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

residential_quota_downselect leads to bad format buildstock #373

Closed
lixiliu opened this issue May 25, 2023 · 3 comments · Fixed by #374
Closed

residential_quota_downselect leads to bad format buildstock #373

lixiliu opened this issue May 25, 2023 · 3 comments · Fixed by #374
Assignees
Labels
bug Something isn't working

Comments

@lixiliu
Copy link
Contributor

lixiliu commented May 25, 2023

Describe the bug
There's a problem with the buildstock created fromresidential_quota_downselect. All "None" fields become empty and I believe there are other formatting issues that are causing these failures on Eagle:

[00:32:57.683956 ERROR] Could not find parameter 'Geometry Building Number Units MF' and option '6.0' in /lib/resources/options_lookup.tsv.

[00:16:10.751502 ERROR] Could not find parameter 'CEC Climate Zone' and option '13.0' in /lib/resources/options_lookup.tsv.

[22:32:00.491794 ERROR] :/ruby/2.7.0/gems/openstudio-workflow-2.3.1/lib/openstudio/workflow/util/measure.rb failed with message Runner error :/ruby/2.7.0/gems/openstudio-workflow-2.3.1/lib/openstudio/workflow/util/measure.rb failed with invalid null reference Expected argument 2 of type std::string const &, but got NilClass nil

The last error I think is tied to None being completely gone.

To Reproduce
This folder contains the yaml, downselect buildstock and original buildstock. You can run the yaml against ResStock develop branch.

I am using bsb env: buildstock-2023.05.0
@nmerket for your awareness. This is potentially caused by recent pandas changes and it does not appear to be an issue for buildstock-2023.01.0

downselect buildstock errors.zip

@lixiliu lixiliu added the bug Something isn't working label May 25, 2023
@afontani
Copy link
Collaborator

Is this might be a float string interpretation issue?

@shorowit
Copy link
Contributor

I think @afontani nailed it. They should be 6 and 13, not 6.0 and 13.0.

@afontani
Copy link
Collaborator

afontani commented May 25, 2023

@nmerket @rajeee Thinking a little more about this, pandas recently changed the way it reads in files and assigns the data types. It might be related to the pandas version. We might have to tag a specific version of pandas or update the way we read in files.

resstock-estimation used pandas<2 (https://github.com/NREL/resstock-estimation/blob/778d24c6f9f98edd5401e2103f3849241529e3ec/setup.py#L34)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants