Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hard-coded Commercial measures into BuildExistingModel #189

Closed
asparke2 opened this issue Oct 16, 2020 · 3 comments
Closed

Move hard-coded Commercial measures into BuildExistingModel #189

asparke2 opened this issue Oct 16, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@asparke2
Copy link
Member

asparke2 commented Oct 16, 2020

There are two measures: add_blinds_to_selected_windows and set_space_type_load_subcategories which are currently hard-coded into the create_osw code. These should be moved into the options_lookup.tsv instead. This will need to be coordinated with ComStock, where the options_lookup.tsv lives.

The corresponding ComStock issue is: https://github.com/NREL/comstock-internal/issues/41

@asparke2 asparke2 added the enhancement New feature or request label Oct 16, 2020
@asparke2 asparke2 self-assigned this Oct 16, 2020
@asparke2
Copy link
Member Author

@rHorsey FYI

@nmerket
Copy link
Member

nmerket commented May 3, 2021

@asparke2 Can we say this is done then?

@asparke2
Copy link
Member Author

asparke2 commented May 4, 2021

@nmerket yep, it's done. Once buildstockbatch is released I'll merge the corresponding ComStock changes.

@asparke2 asparke2 closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants