Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch for automatic deletion of time series parquet files #182

Closed
rHorsey opened this issue Sep 1, 2020 · 2 comments · Fixed by #228
Closed

Switch for automatic deletion of time series parquet files #182

rHorsey opened this issue Sep 1, 2020 · 2 comments · Fixed by #228
Assignees
Labels
enhancement New feature or request postprocessing

Comments

@rHorsey
Copy link
Contributor

rHorsey commented Sep 1, 2020

Is your feature request related to a problem? Please describe.
This bit of code in the postprocessing doesn't have a switch on it and we really really truly need these parquet files for vizstock in particular. The aggregated timeseries files that can be produced from them are useless to us at this point for production runs of ComStock, and soon ResStock.

Describe the solution you'd like
A flag to disable this behavior.

Describe alternatives you've considered
Making the flag default to not clean up, but I think that's not really reasonable...

Additional context
I've spend over 160 hours 'fixing' this for the V1 ComStock run by re-processing over a PB of double-zipped data. I look forward to never doing this ever again.

@rHorsey rHorsey added enhancement New feature or request postprocessing labels Sep 1, 2020
@rHorsey rHorsey self-assigned this Sep 1, 2020
@nmerket
Copy link
Member

nmerket commented Sep 1, 2020

This "fix" seems easy enough, but I'd be interested to understand better what you're trying to do first to see if there's a better way to address the issue.

And, yeah, we really should fix that double zip nightmare.

@asparke2
Copy link
Member

asparke2 commented Apr 23, 2021

@rHorsey I believe that this feature was added via: #212, specifically in these lines of code: https://github.com/NREL/buildstockbatch/pull/212/files#diff-828ab8165bda69957bd58e587d7e6109e847c37d42105953613f25855bf65be9R787-R791

Documentation is under keep_intermediate_files here : https://buildstockbatch.readthedocs.io/en/latest/project_defn.html#eagle-configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request postprocessing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants