Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptic error message about "started_at" when there are no simulation results #151

Closed
nmerket opened this issue May 5, 2020 · 0 comments · Fixed by #152
Closed

Cryptic error message about "started_at" when there are no simulation results #151

nmerket opened this issue May 5, 2020 · 0 comments · Fixed by #152
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nmerket
Copy link
Member

nmerket commented May 5, 2020

Describe the bug
When all the simulations in a buildstockbatch run fail, or when all the jobs run out of time on Eagle, there aren't any simulation_outputs/results_job*.json.gz files. This causes results_df here to be empty or to not have all the columns necessary and to throw and error about there not being the expected started_at column here.

To Reproduce
Steps to reproduce the behavior:

  1. Set up a standard buildstockbatch run, but set the minutes per simulation on Eagle to something low enough the jobs won't finish.

-- or --

  1. Put a poison pill in every simulation (like missing weather files) that will cause all simulations to fail.

Expected behavior
The current error is confusing and doesn't tell a user what went wrong, only a side effect of what went wrong. We should catch this condition that and raise a more informative error.

Logs

image

Platform (please complete the following information):

  • Simulation platform: Eagle mostly, but could happen on any platform.
  • BuildStockBatch version, branch, or sha: v0.17
  • OpenStudio-BuildStock version, branch, or sha: any
  • Local Desktop OS: not relevant
@nmerket nmerket added bug Something isn't working good first issue Good for newcomers labels May 5, 2020
@aspeake aspeake self-assigned this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants