Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeseries aggregation bug #101

Merged
merged 2 commits into from Aug 23, 2019
Merged

Fix timeseries aggregation bug #101

merged 2 commits into from Aug 23, 2019

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Aug 20, 2019 •
edited

Fixes #100 .

Pull Request Description

Fixes #100. If some simulation has failed, the timeseries from those simulation are simply skipped during aggregation.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
    - [ ] Update validation for project config yaml file changes
    - [ ] Update documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)

@rajeee rajeee requested a review from nmerket August 20, 2019 17:57
@rajeee
Copy link
Contributor Author

rajeee commented Aug 20, 2019

@munank

nmerket
nmerket reviewed Aug 23, 2019
View reviewed changes
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay. I haven't ever used this feature much so if you're convinced it's working and the tests pass, it's good enough for me.

@nmerket nmerket merged commit 96d7c54 into master Aug 23, 2019
@nmerket nmerket deleted the fix_timeseries_aggregation_bug branch August 23, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerket nmerket nmerket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postprocessing with timeseries aggregation fails when some simulation has failed
2 participants
@rajeee @nmerket