Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect IMetafieldService.ListAsync(MetafieldFilter filter = null) method #1036

Open
nozzlegear opened this issue Mar 4, 2024 · 0 comments
Open

Remove incorrect IMetafieldService.ListAsync(MetafieldFilter filter = null) method #1036

nozzlegear opened this issue Mar 4, 2024 · 0 comments
Labels
missing or invalid methods

Comments

@nozzlegear
Copy link
Owner

This method is incorrect, all metafield list endpoints require specifying the owner product id/resource type. This method's existence leads to confusion where the developer might think it's possible to list all metafields on the store without a filter.

IMetaFieldService.ListAsync(MetaFieldFilter filter = null, CancellationToken cancellationToken = default)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing or invalid methods
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nozzlegear