Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports #230

Open
Neustradamus opened this issue Jan 8, 2022 · 3 comments

Comments

@Neustradamus
Copy link

Neustradamus commented Jan 8, 2022

Dear @notqmail team,

In first, I wish you a Happy New Year!

Can you add supports of :

  • SCRAM-SHA-1
  • SCRAM-SHA-1-PLUS
  • SCRAM-SHA-256
  • SCRAM-SHA-256-PLUS
  • SCRAM-SHA-512
  • SCRAM-SHA-512-PLUS
  • SCRAM-SHA3-512
  • SCRAM-SHA3-512-PLUS

"When using the SASL SCRAM mechanism, the SCRAM-SHA-256-PLUS variant SHOULD be preferred over the SCRAM-SHA-256 variant, and SHA-256 variants [RFC7677] SHOULD be preferred over SHA-1 variants [RFC5802]".

https://xmpp.org/extensions/inbox/hash-recommendations.html

-PLUS variants:

IMAP:

LDAP:

  • RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

2FA:

IANA:

Linked to:

@DerDakon
Copy link
Member

DerDakon commented Jan 8, 2022

Given that notqmail currently implements neither AUTH nor STARTTLS I don't think this really applies here. And in general I fail to see how this is relevant for SMTP, but that could be my fault.

@Neustradamus
Copy link
Author

Neustradamus commented Jan 8, 2022

@DerDakon: It is good to do not support obsolete and unsecure CRAM-MD5 and DIGEST-MD5:

But SCRAM-SHA-* and SCRAM-SHA-*-PLUS (TLS Binding in more) are missing, the first part is a good start :)

@DerDakon
Copy link
Member

DerDakon commented Jan 9, 2022

Again: notqmail does not implement any of them at the given point. It does not offer any form of authentication, neither as client nor as server. These exist as external patches, some of them are imported to this repository in their own branches for the sole purpose of testing compatibility, but plain notqmail has nothing that uses them.

Should we ever end up doing them we could easily end up using some sort of external authentication provider for anything beyond LOGIN and PLAIN simply to avoid implementing such a thing again, which would then enable us also to choose something that includes SCRAM machanisms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants