Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harcoded path to app.asar causing error when patching notion enhancer after installation folder change #779

Open
AmmarSalmi opened this issue Oct 17, 2022 · 1 comment
Labels
awaiting release This has already been dealt with but is not yet available bug Something isn't working right

Comments

@AmmarSalmi
Copy link

BEFORE MAKING A BUG REPORT, PLEASE READ THE
What is happening?
The python scripts fail to patch stating error message app cannot be found. And the reason is that in the Customization Patcher and Remover the path to app.asar is hard coded in both scripts and assumes that installation folder is %LOCALAPPDATA% while the new notion version is actually being installed in %PROGRAMW6432%/Notion Enhanced.
What should be happening?
The patcher/remover scripts should detect the installation path or prompt user to select it manually instead.

Operating system/browser name & version:
Windows 10
notion-enhancer and/or notion-repackaged version:
Notion Enhancer 2.0.18.1
notion-enhancer configuration (enabled/disabled mods and their settings):

@AmmarSalmi AmmarSalmi added the bug Something isn't working right label Oct 17, 2022
@dragonwocky
Copy link
Member

dragonwocky commented Oct 17, 2022

thanks for noting the new installation location, however you should note that currently the notion-enhancer is only useable via notion-repackaged or the chrome extension - see the other issues in this repository and the #announcements channel in the discord for more information

python script

the notion-enhancer hasn't had any python scripts for a long time. i suspect you are using a very old version of it.

dragonwocky added a commit that referenced this issue Dec 6, 2022
+ added %PROGRAMW6432%/Notion/resources to potential resource paths (#779)
+ clearer separation of programmatic enhancement and cli interface
+ dep on vercel/arg for improved arg parsing
@dragonwocky dragonwocky added the awaiting release This has already been dealt with but is not yet available label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This has already been dealt with but is not yet available bug Something isn't working right
Projects
None yet
Development

No branches or pull requests

2 participants