-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status of x64 plugins affected by ABI changes in N++ 8.3 #11198
Comments
What I miss in N++ is a definition of some NPP_PLUGIN_INTERFACE_VERSION. It should be obligatory for all the N++ plugins (ABI compatibility check). Or am I overlooking something? Unfortunately even the above NPP_PLUGIN_INTERFACE_VERSION does not solve current external apps Scintilla/N++ incompatibility (e.g. NVDA). Scintilla itself should abandon its archaic Edited: |
@rdipardo I would not list TagLEET 1.3.9.7 as fixed. The original author @gstavi of the official TagLEET still has the links in the plugin list and my version is a just a copy I work on making improvements that I wanted that diverged from what @gstavi was supporting at the time. I only create "pre-releases" and they are not in the official plugin list. Further, my 1.3.9.7 version just compiles with the new headers to stop the access violation crash. I do not correct all the Scintilla positions returning Cheers. |
Something like it was suggested after the
The (proposed) ABI check was only intended for CI workflows: notepad-plus-plus/nppPluginList#250 (comment) @ArkadiuszMichalski has developed an automated plugin crash detector: https://github.com/ArkadiuszMichalski/NPP_tools
As you pointed out, SciTE uses only |
The most updated version is 3.1.1.12. |
@rdipardo You may also add: CsvQuery by @jokedst with the open issue at: jokedst/CsvQuery#33 In an email correspondence, he said he was still supporting the plugin and would provide a fix, though no ETA. Cheers. |
Update
|
@xomx ,
notepad-plus-plus/nppPluginList#416 7.7 was the first opportunity, then along comes 8.3 . . . maybe the 3rd time will be the charm? |
If an
Unfortunately a dynamic flexible API/ABI is not easy to implement. So using the above |
@rdipardo AnalysePlugin is on the way to being fixed: v01.13-pre1 |
UpdatePlugins Admin 1.4.9 will feature new stable versions of Comment Wrap, Python Indent and VisualStudioLineCopy. |
See notepad-plus-plus/notepad-plus-plus#11198 for more information
Update
|
@rdipardo I have an alternative for CsvQuery |
Noted. |
P.S. |
I've released a new version of CsvQuery. A pull request for the plugin list has been created. So no need to switch to the alternative :P |
@rdipardo, @jokedst has released the official CsvQuery 1.2.9 update for Notepad++ >= 8.3. You can remove my alternate link and update CsvQuery as working with 1.2.9 version (tested by me on Notepad++ 8.4, though not rigorously). Cheers. |
@jokedst @vinsworldcom |
@donho, thanks - but the list above in the first comment of this issue for CsvQuery should also be updated to reflect: First patched version: 1.2.9 I have removed my forked repo so the link currently in "Suggested alternative ..." no longer works - and with @jokedst 's update, my fork is no longer needed. Cheers. |
@vinsworldcom, you can restore it anytime within the next 30 days at https://github.com/settings/deleted_repositories |
Thanks for pointing me. Just fixed it now. PR into plugin-list will follow soon. |
Updated with newest jN release. |
BTW, informational issues like this one should be pinned to the top of the issue tracker. |
Looking good! There is still room for #11766 |
Closing because:
|
Background
Since version 8.3, x64 builds of Notepad++ can open files >2GiB in size. To achieve this, the type of Scintilla's
Sci_PostionCR
message was changed tointptr_t
, which expands to eight bytes on x86_64 architecture.See:
Plugin List
The following collects what has been reported1 about plugins distributed in x86_64 versions
Related Issues
Only those reported against N++ are listed
To expedite closing duplicates, maintainers are encouraged to mention this issue
Notes
Footnotes
Current as of 2022-11-08 1:52 PM EST ↩
The text was updated successfully, but these errors were encountered: