Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo image ignores ROOT_URL #440

Open
biphobe opened this issue May 30, 2018 · 9 comments
Open

Logo image ignores ROOT_URL #440

biphobe opened this issue May 30, 2018 · 9 comments
Assignees
Labels
Milestone

Comments

@biphobe
Copy link

biphobe commented May 30, 2018

Referenced line:

<img width="225" height="150" src="/logo/new/image_with_text2.png"/>

ATM nosqlclient deployed to a subdirectory with valid ROOT_URL set will not display the correct path to the above image in the browser.

@rsercano rsercano self-assigned this May 31, 2018
@rsercano
Copy link
Member

thank you for the feedback, will check asap

@dikey94
Copy link

dikey94 commented Oct 11, 2018

Same here.

@rsercano
Copy link
Member

rsercano commented Jan 7, 2019

Since this is not a high prio issue, within rewrite this will be resolved I believe, so I'm tagging this with rewrite label

@rsercano rsercano added this to To Do in Nosqlclient 4.0.0 via automation Jan 7, 2019
@rsercano rsercano added this to the v4.0.0 milestone Jan 7, 2019
@rsercano rsercano added bug and removed rewrite labels Feb 17, 2019
@rsercano
Copy link
Member

rsercano commented Feb 23, 2019

Guys have you tried to set ROOT_URL with localhost instead of the domain name ? This seems to be working on our demo with the below environment variables.

123

@rsercano
Copy link
Member

Please re-open this issue if you can't solve it.

Nosqlclient 4.0.0 automation moved this from To Do to Done Feb 24, 2019
@biphobe
Copy link
Author

biphobe commented Feb 25, 2019

I lack privilages to reopen the issue.

@rsercano It doesn't work, mate, the code that I referenced shows clearly that ROOT_URL is not being used in the logo url.

The example that you just mentioned confirms it since it links to /logo/new/image_with_text2.png instead of /demo/logo/new/image_with_text2.png. The image is being displayed only because your server intercepts the /logo/... request and points it to an existing resource...

@rsercano rsercano reopened this Feb 26, 2019
Nosqlclient 4.0.0 automation moved this from Done to To Do Feb 26, 2019
@rsercano
Copy link
Member

Sorry for being so late, I'll check that out ! Issue reopened @biphobe

Nosqlclient 4.0.0 automation moved this from To Do to Done Feb 26, 2019
@rsercano
Copy link
Member

rsercano commented Feb 26, 2019

Hello @biphobe

hopefully it's resolved now with an inconvenient way I think but it's working. Added absoulteUrl directive in front of to the src.

Additionally since this adds ROOT_URL as a prefix to the image URL, I suppose that can cause issues on internal networks, so it's best to set ROOT_URL with a localhost directive.

rsercano added a commit that referenced this issue Mar 31, 2019
@rsercano rsercano reopened this Mar 31, 2019
Nosqlclient 4.0.0 automation moved this from Done to To Do Mar 31, 2019
@rsercano
Copy link
Member

Somehow absoluteUrl doesn't fix logo when a port is used, this needs a rework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants