Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme does not set Terminal highlight group #337

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vds2212
Copy link

@vds2212 vds2212 commented Mar 21, 2023

This pull request intend to solve the issue: theme does not set Terminal highlight group.

Resolves #325

@vds2212 vds2212 requested a review from svengreb as a code owner March 21, 2023 14:36
@svengreb svengreb self-assigned this Apr 2, 2023
@svengreb
Copy link
Member

svengreb commented Apr 2, 2023

Hi @vds2212 👋, thanks for your contribution 👍

I'll review this PR as soon as nordtheme/nord#185 is completed which has the most priority right now to finalize the nordtheme organization migration and finally retire Arctic Ice Studio as Nord and personal brand.

@vds2212
Copy link
Author

vds2212 commented Apr 2, 2023

Thanks for your feedback. Let me know if I can be of any help.

@vds2212
Copy link
Author

vds2212 commented May 26, 2023

I notice that the merging is blocked what can I do to unblock it :-)

@vds2212
Copy link
Author

vds2212 commented May 26, 2023

Here is the version before the change:

Step-01

And here is the version after the change:

Step-02

@svengreb svengreb changed the title Theme does not set Terminal highlight group #325 Theme does not set Terminal highlight group Jun 8, 2023
@svengreb
Copy link
Member

svengreb commented Jun 8, 2023

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the backlog in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@vds2212 Thanks again for your contribution 🚀
The pull request has been added to the backlog and the review will be planned for the next iterations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: review
Development

Successfully merging this pull request may close these issues.

theme does not set Terminal highlight group
2 participants