Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI | Separate the Lint Checks from the Tests #1096

Open
shirady opened this issue Apr 20, 2023 · 0 comments
Open

CI | Separate the Lint Checks from the Tests #1096

shirady opened this issue Apr 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@shirady
Copy link
Contributor

shirady commented Apr 20, 2023

Is your feature request related to a problem? Please describe.
I would like to separate the lint checks from the tests themselves.

Describe the solution you'd like
Separate the lint checks from the tests themselves, in a lint check we would have golangci-lint-action (that we have today) and make lint (which runs today as a dependency of the target test - inside make test). I would like to get the linter CI checks separated from the unit tests.

Describe alternatives you've considered
Leave it as is.

Additional context
PR for example #1094 that the make lint failed on comment and we didn't have the unit tests result (written here).

@shirady shirady added the enhancement New feature or request label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant