Do these lines need to be deleted? #49

DAnn2012 · 2021-07-22T13:51:34Z

@nolimits4web Do these lines need to be deleted?

Line 46 in 9257183

// arr = qsa(selector, document);

Line 92 in 9257183

// scrollTop(top, duration, easing, callback) {

Thanks.

nolimits4web · 2021-07-22T15:04:39Z

Not necessary as these comment don't affect anything

DAnn2012 · 2021-07-22T21:51:54Z

@nolimits4web I understand, but it was because in this way they are also reported in this files:

Line 379 in 9257183

} // arr = qsa(selector, document);

Line 1612 in 9257183

} // scrollTop(top, duration, easing, callback) {

Line 221 in 9257183

} // arr = qsa(selector, document);

Line 1394 in 9257183

} // scrollTop(top, duration, easing, callback) {

and also in this framework7 files (Lines 393-1562):

Thanks.

nolimits4web · 2021-07-23T08:44:49Z

Yes, but anyway it is still doesn't affect anything :) PR is welcome if it bothers you

Provide feedback