Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add export map support #28

Open
nolanlawson opened this issue Jul 11, 2020 · 3 comments
Open

Add export map support #28

nolanlawson opened this issue Jul 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@nolanlawson
Copy link
Owner

This is a new thing in Node.js: https://nodejs.org/api/esm.html#esm_package_entry_points

We could use this to formalize the .cjs versus .js versions in some of the APIs.

I don't know which versions of Node actually support this, though.
@nolanlawson nolanlawson added the enhancement New feature or request label Jul 11, 2020
@nolanlawson
Copy link
Owner Author

nolanlawson commented Aug 16, 2020 •
edited

This may technically be a breaking change, as it restricts access to files that used to be exposed.

@nolanlawson
Copy link
Owner Author

Not sure this is super necessary, since I already only publish JS files that are actually exposed as part of the API.

@nolanlawson
Copy link
Owner Author

The only argument I can think for doing this is to make the relationship between trimEmojiData.js and trimEmojiData.cjs explicit. Every file exposed was meant to be exposed: https://unpkg.com/browse/emoji-picker-element/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nolanlawson