Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import error on index.d.ts #241

Open
SYChoi opened this issue Aug 7, 2023 · 2 comments
Open

Import error on index.d.ts #241

SYChoi opened this issue Aug 7, 2023 · 2 comments

Comments

@SYChoi
Copy link

SYChoi commented Aug 7, 2023

index.d.ts file has an error since request is not a dependency anymore. Should I have to install @types/request individually when I use TS? I think just move @types/request from devDependencies to dependencies can solve this problem, but if there is any other solution, it would be okay. I want to use without any other @types/request install commands in CI/CD.

@odubuc
Copy link

odubuc commented Aug 9, 2023

same issue here, trying to install node-vault for the first time and it cannot compile.

node_modules/node-vault/index.d.ts:7:26 - error TS2307: Cannot find module 'request' or its corresponding type declarations.
7 import * as request from "request";

@odubuc
Copy link

odubuc commented Aug 9, 2023

related to this PR ? #146
I added "@types/request" to my devDependencies to temporarly fix the issue..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants