New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: layout word break #6712
fix: layout word break #6712
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
It seems to overflow content for low-resolution mobile browsers, for example; https://nodejs-jow7mncue-openjs.vercel.app/en/blog/release/v20.12.0 IMO it might be better to use |
yeah - we have dueling solutions here now and we need to slow down and consider our use cases and options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would suggest try
This will both keep the result closest to the current design and bring hyphens to broken words at the end of the lines. Another benefit would be that we don't need to concern media query for such cases further. |
Look we also already tried the hyphens approach. Each approach has its own cons and pros and different side effects. I think is worth going over git history to see what was already attempted and what not and if whatever proposed works well on all scenarios |
I came across this PR after running into this odd issue and trying to fix it myself. For me, personally, justified alignment and normal word break work fine in combination. |
@araujogui could you go over the considerations that both me, Caner and Brian mentioned? 👀 |
Description
Change layout's word break to normal
Validation
Related Issues
Fixes #6711
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.