Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Word Break #6711

Closed
MitchTalmadge opened this issue May 5, 2024 · 2 comments · Fixed by #6712
Closed

Blog Word Break #6711

MitchTalmadge opened this issue May 5, 2024 · 2 comments · Fixed by #6712
Labels

Comments

@MitchTalmadge
Copy link

MitchTalmadge commented May 5, 2024

URL:

https://nodejs.org/en/blog/announcements/v22-release-announce

Browser Name:

Arc

Browser Version:

1.41.0 (49440)

Operating System:

MacOS 14.4.1 (23E224)

How to reproduce the issue:

The blog currently uses word-break: break-all for the body text. This seems like a bug to me. It makes it difficult to read the posts. I would recommend changing it to word-break: normal.

  1. Go to https://nodejs.org/en/blog/announcements/v22-release-announce
  2. Look at the end of each line of text. Many words will be chopped off, not even hyphenated.

It looks like it was introduced in #6680. I think that change was only supposed to affect small screens, like phones, but I am using a full desktop browser on a large screen and having the issue.

Before

Notice the way that every line ends in a broken word.

image

After (word-break: normal)

image

@AugustinMauroy
Copy link
Contributor

I take a look to the pr and I didn't found any reason behind. so let's revert this change.

@AugustinMauroy
Copy link
Contributor

Note

On project we use tailwind so you I'll need to use word-break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants