Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backpressuring in streams - vague example #6453

Open
nenikola opened this issue Mar 5, 2024 · 2 comments
Open

Backpressuring in streams - vague example #6453

nenikola opened this issue Mar 5, 2024 · 2 comments
Labels
content Issues/pr concerning content

Comments

@nenikola
Copy link

nenikola commented Mar 5, 2024

Enter your suggestions in details:

In section explaining Rules specific to readable streams, author states that first example is bad because it doesn't consider return value of a .push. However neither in the next example, nor the one after they show or explain how to properly handle .push. The last example:
image
is trivial as well as it's explanation, and is great miss of even greater opportunity to demonstrate a proper way of doing things for such an important topic.

I hope someone can fix it, I was just researching the matter and it causes a great confusion being written as it is.

@bmuenzenmeyer
Copy link
Collaborator

Would you be able to contribute the fix??

@nenikola
Copy link
Author

nenikola commented Mar 6, 2024

@bmuenzenmeyer I can try but it may be wrong since I just started reading on the topic and figuring it out. I'll propose something tomorrow and hopefully it will be correct.

@AugustinMauroy AugustinMauroy added the content Issues/pr concerning content label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content
Projects
None yet
Development

No branches or pull requests

3 participants